Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't perform ICA cleaning on raw data by default when epochs are present #926

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hoechenberger
Copy link
Member

Fixes #925

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@hoechenberger
Copy link
Member Author

I'm not sure this is the right approach (in terms of, where to do the conditional branching)… @larsoner Could you kindly take a look?

@hoechenberger hoechenberger marked this pull request as ready for review April 18, 2024 10:04
Comment on lines +16 to +18
- When using ICA or SSP with resting-state data, we now automatically produce cleaned raw data files. This
behavior can be controlled via the new [`spatial_filter_raw`][mne_bids_pipeline._config.spatial_filter_raw]
configuration option. (#840, #926 by @larsoner and @hoechenberger)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introduction of writing raw data was actually in 1.6 / #840. So the behavior change here is actually to stop writing files by default. So maybe we should leave the default as True for backward compat. Then this PR is just to add the ability to have False | None.

Personally I think True is the most reasonable default anyway. If you ever want to re-epoch your data (I often do!) then you'll want those preprocessed raw files. And you can cross-check individual runs against the produced epochs, it's more complete to have raw data report at each stage, etc. even though it makes the report longer.

@hoechenberger
Copy link
Member Author

Thanks for your help here, @larsoner, this is much appreciated!

I'd like to hear @SophieHerbst's input as well, esp. since she said they were struggling with disk space usage and all…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't perform ICA cleaning on raw data by default when epochs are present
2 participants